Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
Adds additional pprof dumping in the CL nodes leak detector so leak checks can persist both allocation and in-use memory profiles for post-test analysis.
Changes:
- Dump two Pyroscope memory profiles during
CLNodesLeakDetector.Check: alloc (default) and inuse. - Add per-profile output naming and log the saved profile type/path.
- Add a framework changeset note for the new behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| framework/leak/detector_cl_node.go | Updates leak check to download and save multiple memory pprof profiles (alloc + inuse) with distinct output names and logging. |
| framework/.changeset/v0.15.16.md | Documents the new behavior in the changelog/changeset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tofel
force-pushed
the
dx-3763-dump-two-profiles
branch
from
f97fa25 to
cf09c89
Compare
| [Pyroscope] | ||
| ServerAddress = 'http://pyroscope:4040' | ||
| Environment = 'local' | ||
| LinkTracesToProfiles = true |
There was a problem hiding this comment.
When Pyroscope is configured, then dumping admin profiles fails with error collecting /v2/debug/pprof/profile?seconds=1: status 500: Could not enable CPU profiling: cpu profiling already in use
No description provided.